Re: ODROID C2 + I2C: request for code review and help

[Robert Swindells <rjs%fdy2.co.uk@localhost>]

Vincent DEFERT <vincent.defert%posteo.net@localhost> wrote:
> I'm working on an I2C driver for the amlogic meson architecture, testing 
> it on ODROID C2.
> The configuration is correct, the driver attaches to the FDT and 
> responds to the iic_exec ioctl.
> However, the interrupt handler is never calledand I have no clue why.
>
> It is the first time I write a NetBSD driver, so I'd appreciate a code 
> review.
> I also welcome any advice as to what I can try to make it work. :)
>
> The code can be downloaded at https://www.defert.com/meson-i2c.tgz
> It is intended to be untarred in /usr/src/sys, or wherever else you have 
> your kernel sources.
> It also has a TEST-PGM directory with a test program that writes and 
> reads a 24C256 I2C EEPROM.
>
> My kernel configuration is called ODROID-C2.

Posting /var/run/dmesg.boot could help too, it should show how your
interrupt handler gets registered.

> I had to modify meson-gxbb-odroidc2.dts, so it also needs to be recompiled.
> I have included comments in the files I modified so you can easily 
> locate my changes (search BEGIN_MESONI2C_MOD).

The usual way we do this is to put a file in sys/arch/arm/dts that
overrides nodes in the original dts sources.