pkgsrc-Users archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: [emulators/qemu] Deleted patch is still in distinfo
On Sun, Aug 30, 2026 at 06:43:45PM +0100, Jonathan Perkin wrote:
> > > qemu-11.1.1 pending Build file removed: ../../emulators/qemu/patches/patch-fsdev_file-op-9p.h
>
> The problem here is that PATCHDIR is relative. The vast majority of cases
> use ${.CURDIR}/../.. or similar so that the path resolves to an absolute
> location. I can only find a small handful of packages including qemu that
> omit ${.CURDIR}.
I fixed it in qemu. Please fix the others since you already have a list.
> I could change bob to cd into the package directory first, but I actually
> think this is a class of bug, should be fixed, and should be warned about in
> pkglint.
I always wonder about these weird usage patterns we have, like
- always include files from the category level, i.e.
.include "../../www/webkit-gtk41/Makefile.common"
even thought "../webkit-gtk41/Makefile.common" would also work
- having to have ${.CURDIR} before ../../category/path for
DISTINFO_FILE and PATCHDIR.
Why is this necessary?
Thomas
Home |
Main Index |
Thread Index |
Old Index