Re: rust and new thunderbird

[Havard Eidnes <he%NetBSD.org@localhost>]

> I'm building mail/thunderbird (netbsd-10, pkgsrc-current) on my pkg
> builder box (which is old and not that fast).  It's been going 23h, and
> I see that I should turn down MAKE_JOBS from 3 to 1 for it (on a 2-core
> box with 4G in the dom), as it is leading to a lot of paging.  I don't
> know if this is worse than previous - I know all things mozilla are piggy.
>
> (I have not yet updated rust and retried.)
>
>
> 22245 gdt       27    0  5705M  513M RUN/1      76:07 27.10% 27.10% rustc
> 17087 gdt       78    0  1602M  694M RUN/1       2:00 22.12% 22.12% cc1plus
> 18487 gdt       79    0  1680M 1144M CPU/0       1:32 19.92% 19.92% cc1plus

Yes, it's a pig to build.

I've successfully build tested with rust 1.71.1 from wip/rust.

BTW, for me I had to add the attached patch to make the new
version build.  Not sure what's needed to make just "isnan()" be
available name-space-wise, so I did what the build log suggested.

On my build host (which is quite beefy: 16 physical cores, 32
logical, 128GB memory), csh's "time" reported

29624.386u 2190.747s 37:39.95 1407.7%   13+2k 3155+950026io 10091pf+0w
and
22887.054u 1747.188s 21:30.82 1908.4%   18+2k 76+28544io 2537pf+0w

for the two cycles to complete the build (me adding the attached
patch in-between), just to adjust expectations.

BTW, I noticed in the build log while linking libxul.so:

ld: warning: libfreetype.so.19, needed by /usr/pkgsrc/mail/thunderbird/work/.buildlink/lib/libfontconfig.so, may conflict with libfreetype.so.6

which probably isn't good...  It does start, though, and clicking
around without having it configured also works as one could expect.

Regards,

- Håvard

stest: {81} cat patches/patch-dom_webtransport_api_WebTransportDatagramDuplexStream.cpp
$NetBSD$

Use std::isnan() instead of just isnan(), as that's what's available.

--- dom/webtransport/api/WebTransportDatagramDuplexStream.cpp.orig      2023-08-14 18:19:46.000000000 +0000
+++ dom/webtransport/api/WebTransportDatagramDuplexStream.cpp
@@ -62,7 +62,7 @@ void WebTransportDatagramDuplexStream::S
                                                          ErrorResult& aRv) {
   // https://w3c.github.io/webtransport/#dom-webtransportdatagramduplexstream-incomingmaxage
   // Step 1
-  if (isnan(aMaxAge) || aMaxAge < 0.) {
+  if (std::isnan(aMaxAge) || aMaxAge < 0.) {
     aRv.ThrowRangeError("Invalid IncomingMaxAge");
     return;
   }
@@ -78,7 +78,7 @@ void WebTransportDatagramDuplexStream::S
                                                          ErrorResult& aRv) {
   // https://w3c.github.io/webtransport/#dom-webtransportdatagramduplexstream-outgoingmaxage
   // Step 1
-  if (isnan(aMaxAge) || aMaxAge < 0.) {
+  if (std::isnan(aMaxAge) || aMaxAge < 0.) {
     aRv.ThrowRangeError("Invalid OutgoingMaxAge");
     return;
   }
@@ -94,7 +94,7 @@ void WebTransportDatagramDuplexStream::S
     double aWaterMark, ErrorResult& aRv) {
   // https://w3c.github.io/webtransport/#dom-webtransportdatagramduplexstream-incominghighwatermark
   // Step 1
-  if (isnan(aWaterMark) || aWaterMark < 0.) {
+  if (std::isnan(aWaterMark) || aWaterMark < 0.) {
     aRv.ThrowRangeError("Invalid OutgoingMaxAge");
     return;
   }
@@ -110,7 +110,7 @@ void WebTransportDatagramDuplexStream::S
     double aWaterMark, ErrorResult& aRv) {
   // https://w3c.github.io/webtransport/#dom-webtransportdatagramduplexstream-outgoinghighwatermark
   // Step 1
-  if (isnan(aWaterMark) || aWaterMark < 0.) {
+  if (std::isnan(aWaterMark) || aWaterMark < 0.) {
     aRv.ThrowRangeError("Invalid OutgoingHighWaterMark");
     return;
   }
stest: {82}