Re: Circular dependency on archlinux base system

[klu <kludev%gmail.com@localhost>]

Removing hostname as in below patch works great! I did a code search
with `ag 'TOOLS_PLATFORM.hostname'`. It appears that no package is
using it. Hope it's safe to remove. (I have not checked pkgsrc-wip
though)


diff --git a/mk/tools/replace.mk b/mk/tools/replace.mk
index dc4a2f0498cd..68cd7af20489 100644
--- a/mk/tools/replace.mk
+++ b/mk/tools/replace.mk
@@ -954,7 +954,7 @@ TOOLS_PATH.${_t_}=          ${TOOLBASE}/bin/${_t_}
 # there is no native tool available.
 #
 _TOOLS.coreutils=      basename cat chgrp chmod chown cp cut date      \
-               dirname echo env expr false head hostname id install    \
+               dirname echo env expr false head id install             \
                ln ls mkdir mv nice numfmt printf pwd readlink realpath \
                rm rmdir sleep sort tail tee test touch tr true tsort wc

On Wed, Jul 12, 2023 at 3:01 PM Jonathan Perkin <jperkin%mnx.io@localhost> wrote:
>
> * On 2023-07-12 at 22:50 BST, klu wrote:
>
> >Forgot to ask, how should this be fixed properly? According to [1],
> >hostname is just not part of arch base installation anymore. I got it
> >from `pacman -S inetutils`, but it seems to better not to assume it's
> >always available.
>
> It's a good question.  It's pulled in by default in this section of
> mk/bsd.pkg.mk:
>
>    # These are all of the tools use by pkgsrc Makefiles.  This should
>    # eventually be split up into lists of tools required by different
>    # phases of a pkgsrc build.
>    #
>    USE_TOOLS+=
>
> It would actually be useful if you could remove it from the list there,
> leave it uninstalled, and then see what, if anything, breaks.
>
> As the comment says, we really should remove that entire section at some
> point and just add the tools in the locations where they are required.
> Not only does that help with code quality, it also helps avoid some of
> the costs associated with creating tool wrappers during a package build.
>
> Cheers,
>
> --
> Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
> Open Source Complete Cloud   www.tritondatacenter.com