Re: mail/sendmail appears not to be able to compile on NetBSD-9.99. and beyond if options blacklistd is used

To: Greg Troxel <gdt%lexort.com@localhost>
Subject: Re: mail/sendmail appears not to be able to compile on NetBSD-9.99. and beyond if options blacklistd is used
From: Chavdar Ivanov <ci4ic4%gmail.com@localhost>
Date: Sat, 1 Apr 2023 12:49:45 +0100
FYI I tested the package, it works at least for local mail delivery.
libblocklist.so is indeed included.

On Sat, 1 Apr 2023 at 12:07, Chavdar Ivanov <ci4ic4%gmail.com@localhost> wrote:
>
> In case anyone is interested, the following (manually made) patch to
> sendmail makes it build with blocklistd on -current.
> ..................
>
> ? files/site.config.m4-blocklistd
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/Makefile,v
> retrieving revision 1.141
> diff -u -r1.141 Makefile
> --- Makefile 10 May 2022 13:46:49 -0000 1.141
> +++ Makefile 1 Apr 2023 11:03:43 -0000
> @@ -108,8 +108,8 @@
>  .if !empty(PKG_OPTIONS:Msendmail-ffr-badrcptshutdown)
>   cat ${FILESDIR}/site.config.m4-ffr_badrcptshutdown >>${SITECONFIG}
>  .endif
> -.if !empty(PKG_OPTIONS:Mblacklistd)
> - cat ${FILESDIR}/site.config.m4-blacklistd >>${SITECONFIG}
> +.if !empty(PKG_OPTIONS:Mblocklistd)
> + cat ${FILESDIR}/site.config.m4-blocklistd >>${SITECONFIG}
>  .endif
>
>  post-extract:
> Index: PLIST
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/PLIST,v
> retrieving revision 1.25
> diff -u -r1.25 PLIST
> --- PLIST 4 Jul 2021 07:57:13 -0000 1.25
> +++ PLIST 1 Apr 2023 11:03:43 -0000
> @@ -1,4 +1,4 @@
> -@comment $NetBSD: PLIST,v 1.25 2021/07/04 07:57:13 jnemeth Exp $
> +@comment $NetBSD$
>  bin/hoststat
>  bin/mailq
>  bin/newaliases
> @@ -99,7 +99,7 @@
>  share/sendmail/feature/bcc.m4
>  share/sendmail/feature/bestmx_is_local.m4
>  share/sendmail/feature/bitdomain.m4
> -share/sendmail/feature/blacklist_recipients.m4
> +share/sendmail/feature/blocklist_recipients.m4
>  share/sendmail/feature/block_bad_helo.m4
>  share/sendmail/feature/blocklist_recipients.m4
>  share/sendmail/feature/check_cert_altnames.m4
> @@ -233,4 +233,3 @@
>  share/sendmail/siteconfig/uucp.old.arpa.m4
>  share/sendmail/siteconfig/uucp.ucbarpa.m4
>  share/sendmail/siteconfig/uucp.ucbvax.m4
> -@pkgdir libexec/sm.bin
> Index: distinfo
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/distinfo,v
> retrieving revision 1.69
> diff -u -r1.69 distinfo
> --- distinfo 12 Jan 2023 11:09:34 -0000 1.69
> +++ distinfo 1 Apr 2023 11:03:43 -0000
> @@ -9,18 +9,18 @@
>  SHA1 (patch-ah) = e6be09008b9230ffdd1560aaacbdbb2ee4fb8028
>  SHA1 (patch-ai) = 7a306d7239f4036cd8d80d6dbe2a07eb80f02d13
>  SHA1 (patch-aj) = e65e6fe44380de2f9c397c1a97677eb4ad285433
> -SHA1 (patch-an) = 1481dd98d6aae000e71ba1c42f3d84197a4e4dc0
> +SHA1 (patch-an) = 2b930555d78dd10fc37467bbb6b2f0da1723e0d6
>  SHA1 (patch-ao) = 88dd76b71ad57a8d0efdb6e8518ff01689ecf634
>  SHA1 (patch-aq) = 5c083d9f9f71bcc42811a3d085e936eaaa404c96
> -SHA1 (patch-ar) = 4e9162c96329716f844c0c64efb9d0a2915ad1cb
> +SHA1 (patch-ar) = 5a229036d8db14077debe0295068ca28543b5cd0
>  SHA1 (patch-as) = a36d4bf90f6803734bb686d5809a18ac6d8314ce
>  SHA1 (patch-at) = d0fd0f3826e2309f14fefde65a8653e01cae058e
>  SHA1 (patch-au) = 08a96e145a9c37ba1ba836457157f1ab781380dc
>  SHA1 (patch-av) = bb6ecd69f6b0db22056b492890d2c6369cd08977
> -SHA1 (patch-aw) = 89a0f2c3102f6baea966c8e604f642229ad41dc3
> +SHA1 (patch-aw) = 7412b24479f757efaec43d490e0e8a2a708a382f
>  SHA1 (patch-ax) = 771c9c8a951a09c80eb85233986af1fc7fedbe77
>  SHA1 (patch-ay) = af4c41b9f7671920cd3db95552dc67edffaf729a
> -SHA1 (patch-az) = 53738dc9d3618838a6e6fd2f0ec9c4fd1f19ae2e
> +SHA1 (patch-az) = 1a22371c433bce0445c945ca783aa7e4a1f675b3
>  SHA1 (patch-ba) = c190b11b9874f00a18b9c75b6e734f4a9dd3f68f
>  SHA1 (patch-bb) = 6c86a60af25b02fc0389f1d40f59c5031d9679f1
>  SHA1 (patch-bc) = 9e7346342dfe1ca5d84053b913df4be41a979683
> @@ -28,12 +28,12 @@
>  SHA1 (patch-be) = d2f3397b7880f23f8cbd5d3c4eb5ccfe6a6ca75b
>  SHA1 (patch-bf) = 9c5faf5b38c18623e5ce4ffafc00a4430965e41a
>  SHA1 (patch-bg) = 716c90ff76edbdcb223111412bdd011d4a252ca6
> -SHA1 (patch-bl) = 4fff262691deb2fcacf5013bfeb5aede45783dcd
> -SHA1 (patch-bm) = b1ec82ab5a97c2dc7f7230d31e47c89b7b5ac1d9
> -SHA1 (patch-bn) = 3af37c9d3523d6093181ae3b7d4c25bc8173b7f9
> -SHA1 (patch-bo) = e55b2cb4ee31fdfa593a307b4ec8ca0799f55060
> -SHA1 (patch-bp) = 9a1daac264aba6c4fc39a63a464b942dd25b06eb
> -SHA1 (patch-bq) = 548bf6d373cb49958437548a65803b6f3c6b35d2
> -SHA1 (patch-br) = 1f0b9716906b91ce2b867bf65e5c06ad16749e36
> +SHA1 (patch-bl) = 9236f33f92093deed3305a76e27c0f6118237c4b
> +SHA1 (patch-bm) = 06fc99665d07168652da6a20acdbcc7bf7cdff01
> +SHA1 (patch-bn) = 8d6bef17f8581925b8b262f7e768ab9235da5cf1
> +SHA1 (patch-bo) = a7f2a0a0187b598ab391f131528409b4d41727f5
> +SHA1 (patch-bp) = c8ff1aa3ddc1be48aea8017e3082057e1f206c02
> +SHA1 (patch-bq) = 408ce77d1f463a5cac0065fac135e76893661835
> +SHA1 (patch-br) = 85e8c965db385341be5416233ae8f26a8b5c5341
>  SHA1 (patch-bs) = f73a66b3f747480505b26876430135364e9aa99e
>  SHA1 (patch-sendmail_tls.c) = 42b4af86be50f3b0c79fb3a2699b0c683ab34844
> Index: options.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/options.mk,v
> retrieving revision 1.26
> diff -u -r1.26 options.mk
> --- options.mk 15 Jul 2019 05:30:33 -0000 1.26
> +++ options.mk 1 Apr 2023 11:03:43 -0000
> @@ -8,9 +8,9 @@
>  .include "../../mk/bsd.prefs.mk"
>
>  .for dir in ${COMPILER_INCLUDE_DIRS}
> -.  if exists(${dir}/blacklist.h)
> -PKG_SUPPORTED_OPTIONS+= blacklistd
> -PKG_SUGGESTED_OPTIONS+= blacklistd
> +.  if exists(${dir}/blocklist.h)
> +PKG_SUPPORTED_OPTIONS+= blocklistd
> +PKG_SUGGESTED_OPTIONS+= blocklistd
>  .  endif
>  .endfor
>
> @@ -73,7 +73,7 @@
>  .endif
>
>  ###
> -### NetBSD blacklistd(8) support.
> +### NetBSD blocklistd(8) support.
>  ###
>  # Nothing to do here, activation is done in Makefile
>
> Index: patches/patch-an
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-an,v
> retrieving revision 1.4
> diff -u -r1.4 patch-an
> --- patches/patch-an 4 Jul 2021 07:57:13 -0000 1.4
> +++ patches/patch-an 1 Apr 2023 11:03:43 -0000
> @@ -10,7 +10,7 @@
>  +dnl define(`bldBIN_TYPE', `G')
>   define(`bldINSTALL_DIR', `')
>   define(`bldSOURCES', `main.c alias.c arpadate.c bf.c collect.c
> conf.c control.c convtime.c daemon.c deliver.c domain.c envelope.c
> err.c headers.c macro.c map.c mci.c milter.c mime.c parseaddr.c
> queue.c ratectrl.c readcf.c recipient.c sasl.c savemail.c sfsasl.c
> shmticklib.c sm_resolve.c srvrsmtp.c stab.c stats.c sysexits.c
> timers.c tlsh.c tls.c trace.c udb.c usersmtp.c util.c version.c ')
> -+APPENDDEF(`bldSOURCES',`blacklist.c ')
> ++APPENDDEF(`bldSOURCES',`blocklist.c ')
>   PREPENDDEF(`confENVDEF', `confMAPDEF')
>   bldPUSH_SMLIB(`sm')
>   bldPUSH_SMLIB(`smutil')
> Index: patches/patch-ar
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-ar,v
> retrieving revision 1.3
> diff -u -r1.3 patch-ar
> --- patches/patch-ar 4 Jul 2021 07:57:13 -0000 1.3
> +++ patches/patch-ar 1 Apr 2023 11:03:43 -0000
> @@ -17,7 +17,7 @@
>   anynet_ntoa(&RealHostAddr));
>   }
>
> -+ BLACKLIST_INIT();
> ++ BLOCKLIST_INIT();
>  +
>   if (pipefd[0] != -1)
>   {
> Index: patches/patch-aw
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-aw,v
> retrieving revision 1.7
> diff -u -r1.7 patch-aw
> --- patches/patch-aw 4 Jul 2021 07:57:13 -0000 1.7
> +++ patches/patch-aw 1 Apr 2023 11:03:43 -0000
> @@ -17,8 +17,8 @@
>   { "SetCertAltnames", O_CHECKALTNAMES, OI_NONE },
>   #endif
>
> -+# define O_BLACKLIST   0xf8
> -+ { "UseBlacklist", O_BLACKLIST, OI_NONE },
> ++# define O_BLOCKLIST   0xf8
> ++ { "UseBlocklist", O_BLOCKLIST, OI_NONE },
>   { NULL, '\0', OI_NONE }
>   };
>
> @@ -44,8 +44,8 @@
>   break;
>   # endif
>
> -+   case O_BLACKLIST:
> -+ UseBlacklist = atobool(val);
> ++   case O_BLOCKLIST:
> ++ UseBlocklist = atobool(val);
>  + break;
>  +
>     default:
> Index: patches/patch-az
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-az,v
> retrieving revision 1.4
> diff -u -r1.4 patch-az
> --- patches/patch-az 4 Jul 2021 07:57:13 -0000 1.4
> +++ patches/patch-az 1 Apr 2023 11:03:43 -0000
> @@ -17,7 +17,7 @@
>     (int) tp.tv_sec +
>   (tp.tv_usec >= 500000 ? 1 : 0)
>   );
> -+ BLACKLIST_NOTIFY(BLACKLIST_AUTH_FAIL, fd, "pre-greeting traffic");
> ++ BLOCKLIST_NOTIFY(BLOCKLIST_AUTH_FAIL, fd, "pre-greeting traffic");
>   }
>   }
>   }
> @@ -29,7 +29,7 @@
>  +
>     authenticated:
>  + fd = sm_io_getinfo(InChannel, SM_IO_WHAT_FD, NULL);
> -+ BLACKLIST_NOTIFY(BLACKLIST_AUTH_OK, fd, "AUTH OK");
> ++ BLOCKLIST_NOTIFY(BLOCKLIST_AUTH_OK, fd, "AUTH OK");
>  +
>   message("235 2.0.0 OK Authenticated");
>   authenticating = SASL_IS_AUTH;
> @@ -38,7 +38,7 @@
>   { \
>   SET_AUTH_USER_CONDITIONALLY \
>   message("535 5.7.0 authentication failed"); \
> -+ BLACKLIST_NOTIFY(BLACKLIST_AUTH_FAIL, sm_io_getinfo(InChannel,
> SM_IO_WHAT_FD, NULL), "AUTH FAIL"); \
> ++ BLOCKLIST_NOTIFY(BLOCKLIST_AUTH_FAIL, sm_io_getinfo(InChannel,
> SM_IO_WHAT_FD, NULL), "AUTH FAIL"); \
>   if (LogLevel >= 9) \
>   sm_syslog(LOG_WARNING, e->e_id, \
>     "AUTH failure (%s): %s (%d) %s%s%.*s, relay=%.100s", \
> @@ -49,7 +49,7 @@
>  + int fd;
>  +
>  + fd = sm_io_getinfo(InChannel, SM_IO_WHAT_FD, NULL);
> -+ BLACKLIST_NOTIFY(BLACKLIST_ABUSIVE_BEHAVIOR, fd, "too many bad commands");
> ++ BLOCKLIST_NOTIFY(BLOCKLIST_ABUSIVE_BEHAVIOR, fd, "too many bad commands");
>   message("421 4.7.0 %s Too many bad commands; closing connection",
>   MyHostName);
>
> @@ -61,7 +61,7 @@
>  +
>     stopattack:
>  + fd = sm_io_getinfo(InChannel, SM_IO_WHAT_FD, NULL);
> -+ BLACKLIST_NOTIFY(BLACKLIST_ABUSIVE_BEHAVIOR, fd, "too many bad commands");
> ++ BLOCKLIST_NOTIFY(BLOCKLIST_ABUSIVE_BEHAVIOR, fd, "too many bad commands");
>   message("421 4.7.0 %s Too many bad commands; closing connection",
>   MyHostName);
>
> Index: patches/patch-bl
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-bl,v
> retrieving revision 1.1
> diff -u -r1.1 patch-bl
> --- patches/patch-bl 15 Jul 2019 04:32:49 -0000 1.1
> +++ patches/patch-bl 1 Apr 2023 11:03:43 -0000
> @@ -1,7 +1,7 @@
>  # $NetBSD: patch-bl,v 1.1 2019/07/15 04:32:49 jnemeth Exp $
>
> ---- sendmail/blacklist.c.orig 2018-01-02 20:16:44 UTC
> -+++ sendmail/blacklist.c
> +--- sendmail/blocklist.c.orig 2018-01-02 20:16:44 UTC
> ++++ sendmail/blocklist.c
>  @@ -0,0 +1,57 @@
>  +/*-
>  + * Copyright (c) 2016 The FreeBSD Foundation
> @@ -33,30 +33,30 @@
>  +
>  +/* $FreeBSD$ */
>  +
> -+#ifdef USE_BLACKLIST
> ++#ifdef USE_BLOCKLIST
>  +#include <sm/gen.h>
> -+#include <sendmail.h> /* for EXTERN UseBlacklist */
> ++#include <sendmail.h> /* for EXTERN UseBlocklist */
>  +
> -+#include <blacklist.h>
> -+#include "blacklist_client.h"
> ++#include <blocklist.h>
> ++#include "blocklist_client.h"
>  +
> -+static struct blacklist *blstate;
> ++static struct blocklist *blstate;
>  +
>  +void
> -+blacklist_init(void)
> ++blocklist_init(void)
>  +{
>  +
> -+ if (UseBlacklist)
> -+ blstate = blacklist_open();
> ++ if (UseBlocklist)
> ++ blstate = blocklist_open();
>  +}
>  +
>  +void
> -+blacklist_notify(int action, int fd, const char *msg)
> ++blocklist_notify(int action, int fd, const char *msg)
>  +{
>  +
>  + if (blstate == NULL)
>  + return;
> -+ (void)blacklist_r(blstate, action, fd, msg);
> ++ (void)blocklist_r(blstate, action, fd, msg);
>  +}
>  +
> -+#endif /* USE_BLACKLIST */
> ++#endif /* USE_BLOCKLIST */
> Index: patches/patch-bm
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-bm,v
> retrieving revision 1.1
> diff -u -r1.1 patch-bm
> --- patches/patch-bm 15 Jul 2019 04:32:49 -0000 1.1
> +++ patches/patch-bm 1 Apr 2023 11:03:43 -0000
> @@ -1,7 +1,7 @@
>  # $Id: patch-bm,v 1.1 2019/07/15 04:32:49 jnemeth Exp $
>
> ---- sendmail/blacklist_client.h.orig 2018-01-02 20:16:44 UTC
> -+++ sendmail/blacklist_client.h
> +--- sendmail/blocklist_client.h.orig 2018-01-02 20:16:44 UTC
> ++++ sendmail/blocklist_client.h
>  @@ -0,0 +1,57 @@
>  +/*-
>  + * Copyright (c) 2016 The FreeBSD Foundation
> @@ -33,30 +33,30 @@
>  +
>  +/* $FreeBSD$ */
>  +
> -+#ifndef BLACKLIST_CLIENT_H
> -+#define BLACKLIST_CLIENT_H
> ++#ifndef BLOCKLIST_CLIENT_H
> ++#define BLOCKLIST_CLIENT_H
>  +
> -+#ifndef BLACKLIST_API_ENUM
> ++#ifndef BLOCKLIST_API_ENUM
>  +enum {
> -+ BLACKLIST_AUTH_OK = 0,
> -+ BLACKLIST_AUTH_FAIL,
> -+ BLACKLIST_ABUSIVE_BEHAVIOR,
> -+ BLACKLIST_BAD_USER
> ++ BLOCKLIST_AUTH_OK = 0,
> ++ BLOCKLIST_AUTH_FAIL,
> ++ BLOCKLIST_ABUSIVE_BEHAVIOR,
> ++ BLOCKLIST_BAD_USER
>  +};
>  +#endif
>  +
> -+#ifdef USE_BLACKLIST
> -+void blacklist_init(void);
> -+void blacklist_notify(int, int, const char *);
> ++#ifdef USE_BLOCKLIST
> ++void blocklist_init(void);
> ++void blocklist_notify(int, int, const char *);
>  +
> -+#define BLACKLIST_INIT() blacklist_init()
> -+#define BLACKLIST_NOTIFY(x, y, msg) blacklist_notify(x, y, msg)
> ++#define BLOCKLIST_INIT() blocklist_init()
> ++#define BLOCKLIST_NOTIFY(x, y, msg) blocklist_notify(x, y, msg)
>  +
>  +#else
>  +
> -+#define BLACKLIST_INIT()
> -+#define BLACKLIST_NOTIFY(x, y, msg)
> ++#define BLOCKLIST_INIT()
> ++#define BLOCKLIST_NOTIFY(x, y, msg)
>  +
>  +#endif
>  +
> -+#endif /* BLACKLIST_CLIENT_H */
> ++#endif /* BLOCKLIST_CLIENT_H */
> Index: patches/patch-bn
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-bn,v
> retrieving revision 1.1
> diff -u -r1.1 patch-bn
> --- patches/patch-bn 15 Jul 2019 04:32:49 -0000 1.1
> +++ patches/patch-bn 1 Apr 2023 11:03:43 -0000
> @@ -6,9 +6,9 @@
>   failed messages will be returned to the sender.
>   The default is five days.
>   .TP
> -+UseBlacklist
> ++UseBlocklist
>  +If set, send authentication failure and success notifications to the
> -+.BR blacklistd (8)
> ++.BR blocklistd (8)
>  +daemon.
>  +.TP
>   .RI UserDatabaseSpec= userdatabase
> Index: patches/patch-bo
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-bo,v
> retrieving revision 1.5
> diff -u -r1.5 patch-bo
> --- patches/patch-bo 10 May 2022 13:46:49 -0000 1.5
> +++ patches/patch-bo 1 Apr 2023 11:03:43 -0000
> @@ -1,6 +1,6 @@
>  $NetBSD: patch-bo,v 1.5 2022/05/10 13:46:49 sborrill Exp $
>
> -Add blacklist support.
> +Add blocklist support.
>  Pull up SMTP AUTH fix from 8.17.1.9 as per:
>   https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262935
>
> @@ -10,10 +10,10 @@
>   #endif
>
>   #include "bf.h"
> -+#ifdef USE_BLACKLIST
> -+#include <blacklist.h>
> ++#ifdef USE_BLOCKLIST
> ++#include <blocklist.h>
>  +#endif
> -+#include "blacklist_client.h"
> ++#include "blocklist_client.h"
>   #include "timers.h"
>   #include <sm/exc.h>
>   #include <sm/heap.h>
> @@ -30,7 +30,7 @@
>
>   EXTERN int ConnectionRateWindowSize;
>
> -+EXTERN bool UseBlacklist;
> ++EXTERN bool UseBlocklist;
>  +
>   /*
>   **  Declarations of useful functions
> Index: patches/patch-bp
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-bp,v
> retrieving revision 1.1
> diff -u -r1.1 patch-bp
> --- patches/patch-bp 15 Jul 2019 05:30:33 -0000 1.1
> +++ patches/patch-bp 1 Apr 2023 11:03:43 -0000
> @@ -6,9 +6,9 @@
>   confMILTER_MACROS_DATA Milter.macros.data
>   Macros to transmit to milters
>   after DATA command is received.
> -+confUSE_BLACKLIST UseBlacklist [False] Whether to send authentication
> ++confUSE_BLOCKLIST UseBlocklist [False] Whether to send authentication
>  + failure and success information to
> -+ blacklistd.
> ++ blocklistd.
>
>
>   See also the description of OSTYPE for some parameters that can be
> Index: patches/patch-bq
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-bq,v
> retrieving revision 1.1
> diff -u -r1.1 patch-bq
> --- patches/patch-bq 15 Jul 2019 05:30:33 -0000 1.1
> +++ patches/patch-bq 1 Apr 2023 11:03:43 -0000
> @@ -6,7 +6,7 @@
>   define(`confMILTER_MACROS_ENVFROM', ``i, {auth_type}, {auth_authen},
> {auth_ssf}, {auth_author}, {mail_mailer}, {mail_host}, {mail_addr}'')
>   define(`confMILTER_MACROS_ENVRCPT', ``{rcpt_mailer}, {rcpt_host},
> {rcpt_addr}'')
>   define(`confMILTER_MACROS_EOM', `{msg_id}')
> -+define(`confUSE_BLACKLIST', `False')
> ++define(`confUSE_BLOCKLIST', `False')
>
>
>   divert(0)dnl
> Index: patches/patch-br
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-br,v
> retrieving revision 1.1
> diff -u -r1.1 patch-br
> --- patches/patch-br 15 Jul 2019 05:30:33 -0000 1.1
> +++ patches/patch-br 1 Apr 2023 11:03:43 -0000
> @@ -6,8 +6,8 @@
>   # Name to use for EHLO (defaults to $j)
>   _OPTION(HeloName, `confHELO_NAME')
>
> -+# blacklistd
> -+_OPTION(UseBlacklist, `confUSE_BLACKLIST', `False')
> ++# blocklistd
> ++_OPTION(UseBlocklist, `confUSE_BLOCKLIST', `False')
>  +
>   ifdef(`_NEED_SMTPOPMODES_', `dnl
>   # SMTP operation modes
>
> ----------------------
>
> I haven't actually tested the resulting package, though... I still am
> to configure blocklistd and npf.
>
> Chavdar
>
> On Sat, 1 Apr 2023 at 11:32, Chavdar Ivanov <ci4ic4%gmail.com@localhost> wrote:
> >
> > On Sat, 1 Apr 2023 at 02:06, Greg Troxel <gdt%lexort.com@localhost> wrote:
> > >
> > > Brian Buhrow <buhrow%nfbcal.org@localhost> writes:
> > >
> > > >       hello.  By default, mail/sendmail wants to compile with libblacklist on NetBSD.  However,
> > > > libblacklist was changed to libblocklist some time after 9.x was released.  Searching through
> > > > the CVS logs doesn't reveal when the pkgsrc sources were updated to accommodate this change.
> > > > Am I just missing the updates or has no one tried to use sendmail with NetBSD with versions
> > > > after libblacklist was moved?
> > >
> > > I have CC'd jnemeth who is the maintainer of this package, and Christos
> > > who I think developed the code now know as blocklistd.
> > >
> > > I looked briefly on a netbsd-10 system, and
> > >
> > >   - sendmail builds.  That explains why nobody noticed.
> > >
> > >   - the blacklist option is not available because blacklist.h is not in
> > >     the include path
> > >
> > >   - the option only controls adding a config file
> > >
> > >   - sendmail's build must check for and use the header/lib if present,
> > >     but I can't find where USE_BLACKLISTD is defined in the build.
> > >
> > >   - esndmail's source code does not have support for blocklistd
> > >
> > > and therefore:
> > >
> > >   - I am puzzled by your report.   blacklistd is simply not an option on
> > >     netbsd-10 at the moment.  Perhaps you can state what you did and
> > >     what happened.
> > >
> > >   - It seems obvious that the package needs an update to recognize the
> > >     library with either name, and likely to have the option renamed to
> > >     follow the base system renaming, with compat.
> > >
> > >   - It seems feasible to just rewrite names in the sources
> > >     blacklist->blocklist with a SUBST_SED that is triggered on NetBSD >=
> > >     10.  (NetBSD-current before 10's branch is no longer of interest for
> > >     pkgsrc.)
> >
> > There is no 'blacklist' in the sources now, from the RELEASE_NOTES:
> > ...
> >        CONFIG: FEATURE(`blacklist_recipients') renamed to
> >                 FEATURE(`blocklist_recipients').
> > ...
> >
> > The packages is obsolete, needs some TLC:
> >
> > # find work/sendmail-8.16.1 -type f -exec grep -l blacklist  {} \;
> > work/sendmail-8.16.1/RELEASE_NOTES
> > work/sendmail-8.16.1/cf/feature/blacklist_recipients.m4
> > ...
> > # find work/sendmail-8.16.1 -type f -exec grep -l blocklist  {} \;
> > work/sendmail-8.16.1/RELEASE_NOTES
> > work/sendmail-8.16.1/cf/README
> > work/sendmail-8.16.1/cf/cf/Makefile
> > work/sendmail-8.16.1/cf/cf/knecht.mc
> > work/sendmail-8.16.1/cf/feature/blacklist_recipients.m4
> > work/sendmail-8.16.1/cf/feature/blocklist_recipients.m4
> > work/sendmail-8.16.1/cf/feature/dnsbl.m4
> > work/sendmail-8.16.1/cf/feature/enhdnsbl.m4
> > work/sendmail-8.16.1/cf/m4/proto.m4
> > work/sendmail-8.16.1/contrib/dnsblaccess.m4
> >
> > so I guess s/blacklist/blocklist/g on the files of the package should
> > be a good start.
> >
> >
> > --
> > ----
>
>
>
> --
> ----



-- 
----
References:
- mail/sendmail appears not to be able to compile on NetBSD-9.99. and beyond if options blacklistd is used
  - From: Brian Buhrow
- Re: mail/sendmail appears not to be able to compile on NetBSD-9.99. and beyond if options blacklistd is used
  - From: Greg Troxel
- Re: mail/sendmail appears not to be able to compile on NetBSD-9.99. and beyond if options blacklistd is used
  - From: Chavdar Ivanov
- Re: mail/sendmail appears not to be able to compile on NetBSD-9.99. and beyond if options blacklistd is used
  - From: Chavdar Ivanov
Prev by Date: Re: mail/sendmail appears not to be able to compile on NetBSD-9.99. and beyond if options blacklistd is used
Next by Date: Announcing the pkgsrc-2023Q1 branch
Previous by Thread: Re: mail/sendmail appears not to be able to compile on NetBSD-9.99. and beyond if options blacklistd is used
Next by Thread: Re: mail/sendmail appears not to be able to compile on NetBSD-9.99. and beyond if options blacklistd is used
Indexes:
Home | Main Index | Thread Index | Old Index