pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Please review wip/bwa

Great stuff, thanks. Especially PKG_DEVELOPER and INSTALLATION_DIRS, which I was not aware of. Yeah, I need to update my pkgsrc skills...

I updated my submit checklist and committed some changes to bwa to fix these issues.



On 9/16/15 10:20 AM, Tobias Nygren wrote:
On Wed, 16 Sep 2015 09:36:38 -0500
Jason Bacon <> wrote:

This is the first in a long series of genomics packages I've developed
and plan to submit.
Nice! We do need more people working on scientific software.

pkglint -e runs clean, but I'm inviting some ruthlessly critical
feedback on this one so that future packages will require minimal tampering.
- You need to use REPLACE_PERL (hint: set PKG_DEVELOPER=yes)
- Homepage URL in DESCR is redundant (pkg_info will display HOMEPAGE)
- HOMEPAGE should not have /../
- "USE_LANGUAGES=c" is the default and can be omitted
- I think(?) we recommend using INSTALLATION_DIRS instead of AUTO_MKDIRS

Also, for extra ruthless mode you can try pkglint -Wall.


  Jason W. Bacon

  If a problem can be solved,
  there's no need to worry.
If it cannot be solved, then
  worrying will do no good.

Home | Main Index | Thread Index | Old Index