Re: pkg/60138: protobuf-34.1 is not compiling on AMD64 for me.

["Kimmo Suominen via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR pkg/60138; it has been noted by GNATS.

From: Kimmo Suominen <kim%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/60138: protobuf-34.1 is not compiling on AMD64 for me.
Date: Sat, 28 Mar 2026 15:22:15 +0200

 Looks like it will compile with gcc14, but requiring gcc14 would be
 annoying due to no NetBSD release yet including it (not even the
 upcoming NetBSD 11 release).
 
 Below is the change I made to test compiling with gcc14, but I'm not
 sure if this would be the best (or even correct) approach.  Furthermore,
 I thought that protobuf requires c++17, not later.
 
 Kind regards,
 + Kimmo
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/protobuf/Makefile,v
 retrieving revision 1.102
 diff -u -p -r1.102 Makefile
 --- Makefile	26 Mar 2026 09:31:53 -0000	1.102
 +++ Makefile	28 Mar 2026 13:19:28 -0000
 @@ -19,9 +19,9 @@ HOMEPAGE=	https://github.com/protocolbuf
  COMMENT=	Google protocol buffers
  LICENSE=	modified-bsd
  
 -USE_CXX_FEATURES=	c++17
 +USE_CXX_FEATURES=	c++23
  USE_LANGUAGES=		c c++
 -FORCE_CXX_STD=		c++17
 +FORCE_CXX_STD=		c++23
  
  CMAKE_CONFIGURE_ARGS+=	-Dprotobuf_ABSL_PROVIDER=package
  # FIXME: Currently libupd makes net/grpc build fail.