Re: pkg/54909: glib2 build fails for gsize type

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

The following reply was made to PR pkg/54909; it has been noted by GNATS.

From: Patrick Welche <prlw1%cam.ac.uk@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54909: glib2 build fails for gsize type
Date: Thu, 30 Jan 2020 09:32:47 +0000

 On Thu, Jan 30, 2020 at 05:40:00AM +0000, mlelstv%serpens.de@localhost wrote:
 > The glib2 upstream code doesn't trust size_t but deduces the shortest integer
 > type that matches size_t (which is 'unsigned int' not 'long unsigned int')
 > and the glib2 code then relies on that decision.
 
 and the patch in pkg/54298 simply uses size_t instead of what meson/glib
 decides is equivalent.
 
 > ../glib/tests/overflow.c: In function 'test_checked_gsize_mul':
 
 I didn't consider the tests when doing the switch to size_t (!)
 
 > The patch was introduced to solve pkg/54298. So reverting this will
 > probably cause build problems on netbsd-8 again.
 
 In their wisdom, upstream decided to carry on ignoring the existence of
 size_t, and added more complexity in
 
   https://gitlab.gnome.org/GNOME/glib/commit/505c9544247f27cb6ebf749d0902d53c33dac308
 
 which may solve the build problems that existed on netbsd-8.
 
 Thoughts on the options
 1) soldier on and teach glib about c99 types
 2) give up, have an easier life, and minimise difference with "upstream"
 
 ?