pkg/54910: Locale support unnoticed during configure

[nykula%ukr.net@localhost]

>Number:         54910
>Category:       pkg
>Synopsis:       Locale support unnoticed during configure
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 30 09:25:00 +0000 2020
>Originator:     Denys Nykula
>Release:        current
>Organization:
>Environment:
Linux e11 5.5.0-rc3 #1 SMP Thu Dec 26 01:45:51 UTC 2019 x86_64
>Description:
Musl libc for Linux provides builtin gettext and iconv. Autotools,
checking for these, look for glibc internal definitions and, having
found none, force NLS off regardless of defaults or package options.
This results in .mo files not built, failing PLIST check for flex,
gettext-tools, every gstreamer package, gtk3, libexif, libgpg-error,
libidn, xkeyboard-config etc.
>How-To-Repeat:
On a Linux musl system, cd pkgsrc/x11/gtk3 && bmake install.
>Fix:
Assume locale support during configure

Since nearly no packages in pkgsrc make locale presence configurable, for
any platform, let's dummy out this configure branch and continue the
build assuming the system supports native languages.

diff --git a/mk/configure/gnu-configure.mk b/mk/configure/gnu-configure.mk
index 375100384..08f7fe0fe 100644
--- a/mk/configure/gnu-configure.mk
+++ b/mk/configure/gnu-configure.mk                                     
@@ -187,6 +187,12 @@ _SCRIPT.configure-scripts-osdep=                                   \
        ${CHMOD} +x $$file.override;                                    \
        ${TOUCH} -r $$file $$file.override;                             \
        ${MV} -f $$file.override $$file
+.else
+_SCRIPT.configure-scripts-osdep=                                       \
+       ${AWK} 'sub("USE_NLS=no","true")1' $$file >$$file.override;     \
+       ${CHMOD} +x $$file.override;                                    \
+       ${TOUCH} -r $$file $$file.override;                             \
+       ${MV} -f $$file.override $$file
 .endif
 
 .PHONY: configure-scripts-osdep