Re: pkg/53205: archivers/heirloom-tar.out:tar.c:1021: bad if test ?

[Benny Siegert <bsiegert%gmail.com@localhost>]

The following reply was made to PR pkg/53205; it has been noted by GNATS.

From: Benny Siegert <bsiegert%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/53205: archivers/heirloom-tar.out:tar.c:1021: bad if test ?
Date: Mon, 23 Apr 2018 10:24:18 +0000

 > Source code is
 
 >         while (**bp && (n = strtol(*bp, &x, 10)) <= 0 && (*x!=' ' ||
 *x!='\t'))
 
 > Maybe better code
 
 >         while (**bp && (n = strtol(*bp, &x, 10)) <= 0 && (*x!=' ' &&
 *x!='\t'))
 
 Did you report this upstream? pkgsrc typically does not carry patches for
 such nits because of the associated maintenance cost.
 
 -- 
 Benny