pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/53205: archivers/heirloom-tar.out:tar.c:1021: bad if test ?



> Source code is

>         while (**bp && (n = strtol(*bp, &x, 10)) <= 0 && (*x!=' ' ||
*x!='\t'))

> Maybe better code

>         while (**bp && (n = strtol(*bp, &x, 10)) <= 0 && (*x!=' ' &&
*x!='\t'))

Did you report this upstream? pkgsrc typically does not carry patches for
such nits because of the associated maintenance cost.

-- 
Benny


Home | Main Index | Thread Index | Old Index