Re: kern/55691: rump kernels log "rn_init: radix functions require max_keylen be set"

[Andreas Gustafsson <gson%gson.org@localhost>]

The following reply was made to PR kern/55691; it has been noted by GNATS.

From: Andreas Gustafsson <gson%gson.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: kre%NetBSD.org@localhost
Subject: Re: kern/55691: rump kernels log "rn_init: radix functions require max_keylen be set"
Date: Sat, 17 Oct 2020 12:04:23 +0300

 Earlier, I wrote:
 >   rn_init: radix functions require max_keylen be set
 > 
 > These are printed by rump kernels.  This does not appear to be causing
 > any tests to fail, but the messages clutter the output, and they cause
 > confusion because when a test fails and logs an error message, it's
 > easy to incorrectly assume that the two are related.
 
 This was discussed on current-users in April:
 
   http://mail-index.netbsd.org/current-users/2020/04/08/msg038300.html
   http://mail-index.netbsd.org/current-users/2020/04/08/msg038301.html
 
 In the first of the above messages, kre wrote:
 
 > Note the #ifdef _KERNEL
 >
 > That means that that code is absent in rump
 
 I don't think that's the case - rump is built with _KERNEL defined.
 
 An easy way to reproduce the issue without running the full ATF
 test suite is:
 
   cd /usr/tests/include/sys
   ./t_socket cmsg_sendfd
 
 Running that under gdb and putting a breakpoint in rn_init shows that
 in the following loop,
 
         DOMAIN_FOREACH(dp) {
                 if (dp->dom_maxrtkey > max_keylen)
                         max_keylen = dp->dom_maxrtkey;
         }
 
 there are three domains, "unix", "link", and "route", but they all
 have a dp->dom_maxrtkey of zero.
 
 Presumably they message will be printed by any kernel that is not
 configured with any routable networking domains (not limited to
 rump kernels).
 
 I'm leaning towards simply disabling the message in the _KERNEL case.
 Any objections?
 -- 
 Andreas Gustafsson, gson%gson.org@localhost