Re: kern/55691: rump kernels log "rn_init: radix functions require max_keylen be set"

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/55691; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: Andreas Gustafsson <gson%gson.org@localhost>
Subject: Re: kern/55691: rump kernels log "rn_init: radix functions require
 max_keylen be set"
Date: Sat, 17 Oct 2020 13:13:04 +0200

 On Sat, Oct 17, 2020 at 09:05:02AM +0000, Andreas Gustafsson wrote:
 >  Running that under gdb and putting a breakpoint in rn_init shows that
 >  in the following loop,
 >  
 >          DOMAIN_FOREACH(dp) {
 >                  if (dp->dom_maxrtkey > max_keylen)
 >                          max_keylen = dp->dom_maxrtkey;
 >          }
 >  
 >  there are three domains, "unix", "link", and "route", but they all
 >  have a dp->dom_maxrtkey of zero.
 >  
 >  Presumably they message will be printed by any kernel that is not
 >  configured with any routable networking domains (not limited to
 >  rump kernels).
 >  
 >  I'm leaning towards simply disabling the message in the _KERNEL case.
 >  Any objections?
 
 Isn't it better to set some (new) boolean after that loop has run and change
 the assertion to verify the loop has run already, but also make the
 call to rn_init() depend on max_keylen > 0 ?
 
 Do we have any modules that would load routable protocols later? Do they
 work? How do they interact with this?
 
 Martin