Re: kern/47419: ifconfig on a gif(4) interface doesn't display the MTU

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/47419; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/47419: ifconfig on a gif(4) interface doesn't display the
 MTU
Date: Thu, 10 Jan 2013 16:39:04 +0000

 Please use gnats-bugs@ for bug database traffic and don't send to the
 mailing list directly.
 
    ------
 
 From: David Young <dyoung%pobox.com@localhost>
 To: netbsd-bugs%netbsd.org@localhost
 Subject: Re: kern/47419: ifconfig on a gif(4) interface doesn't display the MTU
 Date: Mon, 7 Jan 2013 20:48:29 -0600
 Mail-Followup-To: David Young <dyoung%pobox.com@localhost>, 
netbsd-bugs%netbsd.org@localhost
 
 On Tue, Jan 08, 2013 at 12:25:00AM +0000, anthony.mallet%laas.fr@localhost 
wrote:
 > >Number:         47419
 > >Category:       kern
 > >Synopsis:       ifconfig on a gif(4) interface doesn't display the MTU
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    kern-bug-people
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Tue Jan 08 00:25:00 +0000 2013
 > >Originator:     Anthony Mallet
 > >Release:        -current
 > >Organization:
 > >Environment:
 > NetBSD cactus 6.99.16 NetBSD 6.99.16 (CACTUS) #26: Tue Jan  8 01:14:43 CET 
 > 2013
 > >Description:
 > ifconfig on a gif(4) does not display the MTU.
 > 
 > The attached patch fixes this for me. It deletes the driver specific
 > handling of the SIOCGIFMTU ioctl() and let ifioctl_common() handle it,
 > as there is no driver specific action to be done.
 > 
 > >How-To-Repeat:
 > 
 > ifconfig gif0 | grep mtu
 > 
 > 
 > >Fix:
 > Index: if_gif.c
 > ===================================================================
 > RCS file: /cvsroot/src/sys/net/if_gif.c,v
 > retrieving revision 1.80
 > diff -u -r1.80 if_gif.c
 > --- if_gif.c    28 Oct 2011 16:42:52 -0000      1.80
 > +++ if_gif.c    8 Jan 2013 00:18:06 -0000
 > @@ -496,9 +496,6 @@
 >                 }
 >                 break;
 >  
 > -       case SIOCGIFMTU:
 > -               break;
 > -
 >         case SIOCSIFMTU:
 >                 if (ifr->ifr_mtu < GIF_MTU_MIN || ifr->ifr_mtu > GIF_MTU_MAX)
 >                         return EINVAL;
 
 FWIW, this looks like the right fix to me.
 
 It's possible I broke that when I did one of several ifioctl()
 overhauls, sorry!
 
 Dave
 
 -- 
 David Young
 dyoung%pobox.com@localhost    Urbana, IL    (217) 721-9981