kern/39947: dbcool(4): sysmon_envsys_destroy() called twice in detach method

[xtraeme%gmail.com@localhost]

>Number:         39947
>Category:       kern
>Synopsis:       dbcool(4): sysmon_envsys_destroy() called twice in detach 
>method
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 18 10:35:00 +0000 2008
>Originator:     Juan RP
>Release:        Latest
>Organization:
>Environment:
NetBSD nocturno 5.99.02 NetBSD 5.99.02 (MASTER) #0: Tue Nov 18 10:04:43 CET 
2008  juan@nocturno:/mnt/raid/build/i386/obj/sys/arch/i386/compile/MASTER i386
>Description:
The dbcool driver calls sysmon_envsys_destroy() twice in the
detach method:

static int
dbcool_detach(device_t self, int flags)
{
        struct dbcool_softc *sc = device_private(self);

        sysmon_envsys_unregister(sc->sc_sme);
        sysmon_envsys_destroy(sc->sc_sme);
        sc->sc_sme = NULL;
        return 0;
}

because sysmon_envsys_unregister() calls sysmon_envsys_destroy() by
itself.
>How-To-Repeat:

>Fix:
Remove the sysmon_envsys_destroy() call in detach function.