tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wedge like devices and newfs

On Jun,Tuesday 2 2009, at 3:11 PM, Manuel Bouyer wrote:

On Tue, Jun 02, 2009 at 12:25:30PM +0200, Adam Hamsik wrote:

On Jun,Tuesday 2 2009, at 11:53 AM, Manuel Bouyer wrote:

On Fri, May 29, 2009 at 07:39:33PM +0200, Adam Hamsik wrote:
If DIOCGDINFO fails, newfs (and other tools using getdiskinfo())
DIOCGWEDGEINFO.  Maybe having zvols should handle DIOCGWEDGEINFO ?
Yes but DIOCGWEDGEINFO is used only to get name of parent device on
DIOCGDINFO is later called. Everything which was received from
was later zeroed and replaced by information from CGDINFO call.

No, if WEDGEINFO was used, part2wedge is not called and informations
WEDGEINFO is not erased.

Ah I see, sorry. Problem is that e.g. for newfs information in
wedge_info are not enough. For working newfs you need DIOCGDINFO because otherwise it will not know sector size. And we are back to main proble that I need to implement disklabels for devices where disklabel doesn't make any sense. I still thing that my patch simplifies this code a lot, add support for wedge like devices and still support old disk devices.

Yes, now I understand why you want to change this.

Ok can I commit this patch later this week then ?



Home | Main Index | Thread Index | Old Index