Re: [PATCH] Fix NetBSD native bootstrap

[Arnaud Lacombe <lacombar%gmail.com@localhost>]

Hi,

On Thu, Dec 9, 2010 at 6:47 AM, Joseph S. Myers 
<joseph%codesourcery.com@localhost> wrote:
> On Wed, 8 Dec 2010, Arnaud Lacombe wrote:
>
>> For this patch I implemented Joseph S. Myers suggestion to define USER_H in
>> config/t-netbsd. This may be cleaner than the last patch in PR/38182 which
>> affect all target. In the mean time, I removed other headers the base system 
>> is
>> providing. stdarg.h is still needed because the host stdarg.h still reference
>> the old __builtin_stdarg_start(). stdfix.h is missing from the base system, 
>> so I
>> kept it in the include list.
>>
>> Bootstrapped on i386-unknown-netbsdelf5.99.25, regression tests pending.
>
> You'll want to check those results carefully for any conformance test
> (gcc.dg/c[91]*) failures indicating header problems.  In particular, the
> testsuite verifies that C1X definitions are present in <float.h>; if they
> aren't present on NetBSD you'll want to keep GCC's <float.h> or fix
> NetBSD's with fixincludes.
>
This definitively introduced regressions, I guess I'll split the
original patch, one addressing the bootstrap issue and one eventually
using more system provided header. What would be the better way to
proceed ? keep using gcc's headers or fixing the system one, by either
fixing that upstream or through fixincludes ?

Thanks,
 - Arnaud