* On 2023-09-08 at 12:50 BST, Taylor R Campbell wrote:
Date: Fri, 8 Sep 2023 12:10:59 +0100 From: Jonathan Perkin <jperkin%mnx.io@localhost> A patch that fixes these issues, as well as testing notes, is available here for review: https://gist.github.com/jperkin/6615a3fea7368e353e5c9dd48afce0bcLGTM, with two nits: - Why bother counting errors if you're just going to reduce them to a boolean indicator in the end? Maybe just store a boolean error indicator?
In case someone wanted to enhance the output at a later point to include the number of errors.
- Why fprintf(stderr, "...") for some issues and warnx("...) for
others? Maybe use the same type/shape of output for all errors?
I'm not hugely keen on the program prefix being output, and didn't want to change existing warns that have them, but this isn't strongly held if others also want uniformity.
-- Jonathan Perkin - mnx.io - pkgsrc.smartos.org Open Source Complete Cloud www.tritondatacenter.com