tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg_admin check vs ruby



Taylor R Campbell <campbell+netbsd-tech-pkg%mumble.net@localhost> writes:

> LGTM, with two nits:
>
> - Why bother counting errors if you're just going to reduce them to a
>   boolean indicator in the end?  Maybe just store a boolean error
>   indicator?

Without thought I lean to a single stderr  message with the count just
before exit.   

> - Why fprintf(stderr, "...") for some issues and warnx("...) for
>   others?  Maybe use the same type/shape of output for all errors?

Agreed to be consistent, and I'm also fine with dropping the program
name for stderr output.


Home | Main Index | Thread Index | Old Index