tech-pkg archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg_admin check vs ruby
> Date: Fri, 8 Sep 2023 12:10:59 +0100
> From: Jonathan Perkin <jperkin%mnx.io@localhost>
>
> A patch that fixes these issues, as well as testing notes, is available
> here for review:
>
> https://gist.github.com/jperkin/6615a3fea7368e353e5c9dd48afce0bc
LGTM, with two nits:
- Why bother counting errors if you're just going to reduce them to a
boolean indicator in the end? Maybe just store a boolean error
indicator?
- Why fprintf(stderr, "...") for some issues and warnx("...) for
others? Maybe use the same type/shape of output for all errors?
Home |
Main Index |
Thread Index |
Old Index