tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Making DESTDIR support mandatory

Thanks for your feedback.

On Wed, 04 May 2011 22:14:21 +0900, Greg Troxel <> 

That looks ok to me during a 3-minute read.  The only thing I noticed

  +.if ${_USE_DESTDIR} != "no"
  +       ${LN} ${PKGFILE} ${REAL_PKGFILE} 2>/dev/null || \
  +       ${CP} -p ${PKGFILE} ${REAL_PKGFILE}

should proably be ${CP} -pf.

Yes, probably more safe, tough it will not do `cp' if ${REAL_PKGFILE} already 
The target is not smart, it should be changed...

OBATA Akio /

Home | Main Index | Thread Index | Old Index