Re: bsd.own.mk - Re: pkg/44425: devel/lua-alt-getopt install problem

[Hauke Fath <hf%spg.tu-darmstadt.de@localhost>]

At 23:30 Uhr +0100 20.01.2011, Joerg Sonnenberger wrote:
>> may I ask you to look at the above patch before venting, and tell me where,
>> in your view, it goes wrong?
>
>It doesn't fix any of the other side effects.

Like what? Care to elaborate?

> Haev you considered
>looking through bsd.own.mk first for why you hit this in first place?

Again, what are you referring to?

>> Arguably, <bsd.own.mk> has no business configuring install target related
>> variables (here: INSTPRIV) when you (or pkgsrc) set NEED_OWN_INSTALL_TARGET
>> in order to signal you'll take care of installation yourself.
>
>NEED_OWN_INSTALL_TARGET is a red hering.

<snip>
#
# NEED_OWN_INSTALL_TARGET is set to "no" by pkgsrc/mk/bsd.pkg.mk to
# ensure that things defined by <bsd.own.mk> (default targets,
# INSTALL_FILE, etc.) are not conflicting with bsd.pkg.mk.
#
NEED_OWN_INSTALL_TARGET?=       yes
</snip>

which should naturally cover any variables which influence install(8).

What is lacking here, your idiomatic expressions, or your reading skills?

But... suit yourself. I can easily maintain a one-line patch locally, and
if anybody else should run into the issue, there's always the list archive.

        hauke

-- 
     The ASCII Ribbon Campaign                    Hauke Fath
()     No HTML/RTF in email            Institut für Nachrichtentechnik
/\     No Word docs in email                     TU Darmstadt
     Respect for open standards              Ruf +49-6151-16-3281