Re: Patch name changes

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Thu, Jun 10, 2010 at 02:53:03PM +0200, Tobias Nygren wrote:
> There may be situations where case-insensitivity presents a problem:
> some packages have for example both Makefile and makefile. We should
> take some measures (like having pkglint complain) to prevent people
> from checking in patches that will break case-insensitive checkouts of
> pkgsrc.

Good point, though I don't expect that even if a package has both
"makefile" and "Makefile" we'll need to patch both.

> I don't know if we have any patches where there's whitespace in the
> path name. If so, the above sed-fu should translate them to
> something suitable.

Currently, pkgsrc contains no patches for files with spaces.[1]
On the off chance, we could just replace spaces with _ as well, I
don't think that will cause collisions...

Cheers,
 Thomas


[1]
# cd /usr/pkgsrc/
# grep -r ^\+\+\+ . > ~/patch-file-names
# sed "s/.*:\+\+\+ //" ~/patch-file-names | grep '[     ]' |grep -Ev '^[^       
]*[     ]*(20[01][0-9]|Mon|Tue|Wed|Thu|Fri|Sat|Sun|199[0-9]|[0-9]?[0-9] 
(Jan|Feb|Mar|Apr|May|Jun|Jul|Aug|Sep|Oct|Nov|Dec)).*$' | less