Re: Proposed patch for libnbcompat to improve support of OpenBSD, Interix and Haiku

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Sat, Jan 16, 2010 at 10:44:54PM +0900, OBATA Akio wrote:
> 1. kill __weak_alias in db1 part, same as other part in libnbcompat. 
> (PR#42102, for OpenBSD)

Just remove them, don't #if 0 them.

> 2. No NBBY in Haiku, define as 8 in files/nbcompat/db.h.

Fine.

> 3. check libntework for socket in configure (Haiku)

Fine.

> 3. check endian.h in configure and use it in files/nbcompat/endian.h (Haiku)

Why exactly?

> 4. check optarg same as optind, it is used in files/nbcompat/unistd.h, but 
> never checked.

Fine.

> 5. check optreset with getopt.h in configure, include getopt.h in 
> files/nbcompat/getopt.h,
>    and guard redefinitions, for Interix-6.0 (PR#42379).

I explicitly don't think getopt.h should be pulled in by
nbcompat/getopt.h. I also don't think optreset should be checked as
defined by getopt.h...

Joerg