tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: proposed patches for bmake (Interix and Haiku)

On Sat, Jan 16, 2010 at 05:47:18PM +0900, OBATA Akio wrote:
> Attached patches are acceptable for devel/bmake?

Please talk with sjg about them. Avoid direct changes.
I strongly dislike the way patch-1 is done. If any, it should get
abstracted into a proper compat function and use a macro to switch
between real vfork and the compat version.

> patch-2:
> On Haiku, failed to unit-test.
> Set MACHINE_ARCH for i386.
> For Haiku, remain one problem, lack of ar.h,
> no ARMAG, SARMAG and struct ar_hdr definitions, then failed to compile arch.c.

Detect the presence and define them otherwise.


Home | Main Index | Thread Index | Old Index