tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: splnet() surrounding in6_control1()

On Fri, May 08, 2009 at 04:37:50PM +0300, Elad Efrat wrote:
> Hi,
> In in6_control() there seems to be an splnet() surrounding the call to
> in6_control1().
> Without going into debate whether or not splnet() around the entire
> function is necessary, at the very least it prevents me from using
> real kauth(9) calls.
> Therefore, I would like to
>   - add a switch statement in in6_control(), where we currently issue
> the kauth(9) call, and perform the call only for the cases where
> in6_control1() checks for the "privileged" variable
>   - modify in6_control1() to not take a "privileged" variable anymore,
> and instead place a comment ("/* Privileged, see in6_control(). */" or
> something) where the variable used to be checked
> Are there any objections to such a change?

Do not make this change without sending a patch for review.  Provide at
least 72 hours for review before committing.


David Young             OJC Technologies      Urbana, IL * (217) 278-3933

Home | Main Index | Thread Index | Old Index