tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Using coccinelle for (quick?) syntax fixing



On Sat, Aug 14, 2010 at 01:36:15PM +0200, Jean-Yves Migeon wrote:
 > > I would say don't do __func__ for messages like this; it doesn't
 > > really serve much purpose vs. typing in a name, causes the observable
 > > behavior to change silently if the code gets reorganized, and makes it
 > > much harder to grep the source for an error message you're seeing.
 > 
 > Understood

not a big deal though.

 > > Changing it to use aprint_whatnot_foo(), though, might be worthwhile...
 > 
 > Hmm, I thought aprint_* functions were essentially for autoconf messages?

Erm... um, yeah, never mind, I was thinking of the way they
automatically rope in the device name and unit number.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index