tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Using coccinelle for (quick?) syntax fixing



On Tue, 10 Aug 2010 07:35:15 +0700, Robert Elz <kre%munnari.OZ.AU@localhost> 
wrote:
> Date:        Mon, 09 Aug 2010 18:19:28 +0200
> One obvious example is that it makes it much harder in the future to
> pullups of
> fixes to code in this area to earlier NetBSD versions - the diffs show
all
> of this meaningless churn as well as the real change.   The same for
anyone
> looking to see why something that used to work no longer does - you
might
> be 
> sure that your changes cannot possibly do any harm, but all someone else
> sees is a whole bunch of files changed between the version that worked
> last 
> week, and the new version that doesn't work this week, that they're
going
> to have to filter through to figure out what change actually broke
things,
> even if your change was not responsible (and it probably wouldn't be)
> you've
> caused lots of needless unnecessary work.
> 
> Please don't.

I won't; indeed, it makes pull-up and backporting difficult. I'll leave
the cocci files on the wiki, so as others could use them on their branch,
new files, etc.

But the NULL deref fixes will go in eventually, and I will probably ask
for a pull up too ;)

-- 
Jean-Yves Migeon
jeanyves.migeon%free.fr@localhost


Home | Main Index | Thread Index | Old Index