Re: Move the vnode lock into file systems

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

Bill Stouder-Studenmund <wrstuden%netbsd.org@localhost> wrote:
> > > Vaguely related to which, does anyone object to wrapping VOP_UNLOCK in
> > > a vn_unlock() function (doing nothing extra), so as to be symmetric
> > > with vn_lock()? I think I've mentioned this before, but I'm not sure,
> > > and if so it was a while back...
> > 
> > I think it would be useful to have symmetric vn_unlock(), yes.  Can be a
> > static inline in vnode.h header.
> 
> If you're striving for clean KPI, don't do static inline in header files. 
> :-)

Generally - yes.  Not always necessary though, if API is just partly public.

However, since we have file-systems as modules these days - yeah, I take my
thought back, plus VFS is heavy-weight anyway. :)

-- 
Mindaugas