Re: Move the vnode lock into file systems

[Andrew Doran <ad%NetBSD.org@localhost>]

On Tue, Jun 29, 2010 at 04:23:53PM +0100, Mindaugas Rasiukevicius wrote:
> David Holland <dholland-tech%netbsd.org@localhost> wrote:
> > Vaguely related to which, does anyone object to wrapping VOP_UNLOCK in
> > a vn_unlock() function (doing nothing extra), so as to be symmetric
> > with vn_lock()? I think I've mentioned this before, but I'm not sure,
> > and if so it was a while back...
> 
> I think it would be useful to have symmetric vn_unlock(), yes.  Can be a
> static inline in vnode.h header.

vn_unlock() would be dressing, which is fair enough. Consider that vn_lock()
and LK_RETRY appear to have no legitimate purpose now that VFS has been
multithreaded, with the result that the clowning about with v_interlock ->
v_lock handoff is dead.  VOP_LOCK() and VOP_UNLOCK() are all that's
needed.