On Sat, 8 Aug 2009, Paul Goyette wrote:
Further comment/criticism is certainly welcomed. In the absence of any
objection, I'd like to commit this in the next 7 to 10 days.
+/*
+ * Send a filled out parameter structure to the drive to
+ * set it into the desire modes etc.
+ */
+int
+st_mode_select(struct st_softc *st, int flags)
+{
+ u_int select_len;
+ struct select {
+ struct scsi_mode_parameter_header_6 header;
+ struct scsi_general_block_descriptor blk_desc;
+ u_char sense_data[MAX_PAGE_0_SIZE];
+ } select;
+ struct scsipi_periph *periph = st->sc_periph;
+
+ select_len = sizeof(select.header) + sizeof(select.blk_desc) +
+ st->page_0_size;
should select be __packed?
I see it wasn't originally, but the select_len doesn't take into account
any possible padding and the comment implies that this will be sent direct
to the device..