tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Implement mode_select for atapi tape drives - round 4

On Sat, Aug 08, 2009 at 08:01:36PM -0700, Paul Goyette wrote:
> >As David Young pointed out, it might be better to extract the set_mode 
> >code out from both st_atapi.c and st_scsi.c into something common. 
> >I'll take a look at doing that, and see if I can reconcile the 
> >differences between them.
> OK, that wasn't so hard!    :)
> The attached patch moves the mode_select functionality into common code 
> in st.c and invokes the common routine for both scsi and atapi tapes.
> It also replaces a numeric constant with some sizeof's when calculating 
> the size of the mode_select command buffer, clears the entire buffer, 
> and has a KASSERT to ensure that the page_0_size loaded from the quirk 
> table is valid.
> Further comment/criticism is certainly welcomed.  In the absence of any 
> objection, I'd like to commit this in the next 7 to 10 days.

Looks good so far. 

Manuel Bouyer <>
     NetBSD: 26 ans d'experience feront toujours la difference

Home | Main Index | Thread Index | Old Index