Re: Implement mode_select for atapi tape drives - round 4

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Sun, Aug 09, 2009 at 09:29:05AM +0100, Iain Hibbert wrote:
> On Sat, 8 Aug 2009, Paul Goyette wrote:
> 
> > Further comment/criticism is certainly welcomed.  In the absence of any
> > objection, I'd like to commit this in the next 7 to 10 days.
> 
> +/*
> + * Send a filled out parameter structure to the drive to
> + * set it into the desire modes etc.
> + */
> +int
> +st_mode_select(struct st_softc *st, int flags)
> +{
> +     u_int select_len;
> +     struct select {
> +             struct scsi_mode_parameter_header_6 header;
> +             struct scsi_general_block_descriptor blk_desc;
> +             u_char sense_data[MAX_PAGE_0_SIZE];
> +     } select;
> +     struct scsipi_periph *periph = st->sc_periph;
> +
> +     select_len = sizeof(select.header) + sizeof(select.blk_desc) +
> +                  st->page_0_size;
> 
> should select be __packed?

Yes, it should probably be. I know most hardware structures are not
declared __packed in the scsipi code, we've been luky this didn't cause
issues for now ...

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--