[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: Fixes for ffs/logging issues for 5.0, for review
On Sun, Feb 22, 2009 at 10:03:31PM +0900, YAMAMOTO Takashi wrote:
> > Here is an updated version of the diff:
> > http://www.netbsd.org/~ad/ffs-fixes4.diff
> > - Fix further problems with mixing log/non-log / and /foo. I hope this is
> > finally correct. I can't provoke any of the panics I have seen mentioned.
> > This introduces a bunch of copy-and-pasted code but it can be trimmed back
> > one softdep is removed (I will do this after the patch is committed).
> why didn't you make ffs_fsync call VFS_FSYNC?
> otherwise a non-ffs filesystem which relies on VFS_FSYNC doesn't
> work if /dev is ffs.
> (there are no such a filesystem in tree currently, tho.)
^ This is why I didn't think to add the VFS_FSYNC call (I agree it should be
Main Index |
Thread Index |