Re: CVS commit: src/sys/dev/pci

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2019/01/28 15:33, Jason Thorpe wrote:
> > On Jan 28, 2019, at 8:11 AM, Masanobu SAITOH <msaitoh%execsw.org@localhost> wrote:
> >
> > On 2019/01/28 15:07, Jason Thorpe wrote:
> > > Doesn’t it seem a little dangerous to just blindly enable?
> >
> > You mean it should be enable only when the secondary bridge is configured
> > correctly?
> >
> > Both FreeBSD and OpenBSD blindly enabled it. One of the difference between
> > NetBSD and others is that they configure unconfigured bridge.
>
> Right, if the address decoders aren't programmed properly, it seems like you could get into all sorts of trouble.

done:
> Module Name:	src
> Committed By:	msaitoh
> Date:		Tue Jan 29 09:25:52 UTC 2019
>
> Modified Files:
> 	src/sys/dev/pci: ppb.c
>
> Log Message:
>  If the secondary bus is configured and the bus mastering is not enabled,
> enable it. Suggested by thorpej@.



> I really feel like the correct way to solve the problem is to fully configure the bus using information from ACPI.

 For ACPI, I'm not familiar with ACPI's PCI stuff, so please someone...
Even if it's implemented, some BIOS/UEFI don't configure add-in PCI bridge
behind bridge...

 And also please someone to write hotplug code (especially for hot insertion)...

> -- thorpej


--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)