Re: CVS commit: src/sys/dev/pci

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2019/01/28 15:07, Jason Thorpe wrote:
> Doesn’t it seem a little dangerous to just blindly enable?

 You mean it should be enable only when the secondary bridge is configured
correctly?

 Both FreeBSD and OpenBSD blindly enabled it. One of the difference between
NetBSD and others is that they configure unconfigured bridge.

> -- thorpej
> Sent from my iPhone.
>
> > On Jan 28, 2019, at 6:09 AM, SAITOH Masanobu <msaitoh%netbsd.org@localhost> wrote:
> >
> > Module Name:    src
> > Committed By:    msaitoh
> > Date:        Mon Jan 28 04:09:51 UTC 2019
> >
> > Modified Files:
> >     src/sys/dev/pci: ppb.c
> >
> > Log Message:
> > Explicitly enable bus masterling in case BIOS, UEFI or firmware don't enable
> > it. Might fix PR kern/53811.
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.65 -r1.66 src/sys/dev/pci/ppb.c
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.


--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)