Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/pci



On Tue, Jan 29, 2019 at 04:16:30PM +0900, Masanobu SAITOH wrote:
> On 2019/01/29 2:51, Christoph Badura wrote:
> >Wouldn't it be better to prevent this kind of bug in the future by putting
> >the decision which method to use into a switch-statement and have the
> >compiler worry about ordering? (And duplicates and omissions.)
> 
> I think so and I'm going to simplify such type of checks (I have unfinished code
> in locally). The reason why I committed the above change only is to make
> the change understandable by separating from other changes.

I wasn't aware that you were planning to do that.  Excellent!
Thank you for doing that.

--chris


Home | Main Index | Thread Index | Old Index