Re: CVS commit: src/external/cddl/osnet

[haad <haaaad%gmail.com@localhost>]

On Fri, Jan 14, 2011 at 1:01 AM, matthew green <mrg%eterna.com.au@localhost> 
wrote:
>
>> Module Name: Âsrc
>> Committed By: haad
>> Date: Â Â Â Â Thu Jan 13 23:18:24 UTC 2011
>>
>> Modified Files:
>> Â Â Â src/external/cddl/osnet: Makefile.zfs
>> Â Â Â src/external/cddl/osnet/lib/libavl: Makefile
>> Â Â Â src/external/cddl/osnet/lib/libnvpair: Makefile
>> Â Â Â src/external/cddl/osnet/lib/libuutil: Makefile
>> Â Â Â src/external/cddl/osnet/lib/libzfs: Makefile
>>
>> Log Message:
>> Fix zfs Makefiles + debug, don't add -g by default only when MKDEBUG is
>> enabled. Fix header assert conflicts + bump WARNS for some libs.
>
> please revert this. Âyou shouldn't set DBG like this.
> DBG is usually default to -O2 (but there are other values,
> see bsd.sys.mk.), and if you force it to "-g" then you've
> actually made all these binaries use no -O2 just -g.
>
> it's also supposed to be user-settable value.
>
> i think you can just remove setting DBG here and leaving
> the rest of the system (MKDEBUG, etc) to set -g in the
> right place anyway. Âif not, that's the right place to
> fix it.

I would like to have zfs build with -g -O0 built by default,
this is wip code and there is high probability that someone
will find some problem with it, therefore I would like to have
debugging symbols already builtin.




-- 


Regards.

Adam