Re: CVS commit: src/lib/libp2k

[Antti Kantee <pooka%cs.hut.fi@localhost>]

On Fri Jan 14 2011 at 08:42:45 +0000, David Holland wrote:
> On Fri, Jan 07, 2011 at 11:15:31AM +0000, Antti Kantee wrote:
>  > Modified Files:
>  >    src/lib/libp2k: p2k.c
>  > 
>  > Log Message:
>  > Remove the componentname-saving code since it was addressing
>  > SAVENAME/HASBUF/SAVESTART and they don't exist anymore (and the
>  > removed code didn't compile on nb5).
> 
> Unfortunately, you still need that code for now, because many fses set
> flags in the componentname in lookup and expect them to still be there
> later. Depending on exactly what you were trying, this may explain
> some of the problems you've just seen with whiteouts...

It does not explain them for quite a few reasons:

1) this code is not used in the whiteout tests (!!)
2) the now-removed code only affected rename
3) puffs does not support unions, making all debate of support at
   the server level purely academic

Do you have some relevant scenarios where "fses set flags in
componentname"?

-- 
älä karot toivorikkauttas, kyl rätei ja lumpui piisaa