Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/external/cddl/osnet



> Module Name:  src
> Committed By: haad
> Date:         Thu Jan 13 23:18:24 UTC 2011
> 
> Modified Files:
>       src/external/cddl/osnet: Makefile.zfs
>       src/external/cddl/osnet/lib/libavl: Makefile
>       src/external/cddl/osnet/lib/libnvpair: Makefile
>       src/external/cddl/osnet/lib/libuutil: Makefile
>       src/external/cddl/osnet/lib/libzfs: Makefile
> 
> Log Message:
> Fix zfs Makefiles + debug, don't add -g by default only when MKDEBUG is
> enabled. Fix header assert conflicts + bump WARNS for some libs.

please revert this.  you shouldn't set DBG like this.
DBG is usually default to -O2 (but there are other values,
see bsd.sys.mk.), and if you force it to "-g" then you've
actually made all these binaries use no -O2 just -g.

it's also supposed to be user-settable value.

i think you can just remove setting DBG here and leaving
the rest of the system (MKDEBUG, etc) to set -g in the
right place anyway.  if not, that's the right place to
fix it.


.mrg.


Home | Main Index | Thread Index | Old Index