Re: CVS commit: src/sys/dev/pci

[Michael <macallan%NetBSD.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Dec 24, 2010, at 5:07 AM, Izumi Tsutsui wrote:

> > > > Modified Files:
> > > >    src/sys/dev/pci: voyagerfb.c
> > >
> > > > Log Message:
> > > > read 32bits instead of 64bits and truncate the upper 32bits
> > >
> > > Please stop making unnecessary changes to drivers you can't test on
> > > actual hardware.
> >
> > Sorry, should have mentioned this makes the i386 ALL kernel linking.
>
> Adding a bogus fix to make ALL buildable is quite silly.
>
> bus_space_read_8(9) is a documented MI API and
> MD implementation should provide bus_space_read_8()
> if the machine really needs the driver in its kernel,
> or don't enable the device on i386.

I wrote voyagerfb for the Gdium Liberty, a MIPS-based netbook. The  
graphics controller is part of a Silicon Motion SM502 which you're not  
likely to find in anything x86 ( probably because it lacks VGA  
compatibility ) but which seems to be popular with chinese MIPS  
hardware vendors. As far as I can tell there is no reason to have it  
in any i386 config.

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBTRVjnspnzkX8Yg2nAQKrSQf9FJvuxdynVOZ4PKrQLbBw69nHaQuki3L/
VzZwC65LOQ70PEzO2TPJhVlsN6h3CK8v4KKj5CdE0r5K1/7jAixCCX5k0GvjEmxR
CGKo7tQ+OuN1jlsC/tsW4g8hqB/5bsPVSfcmCCX1WbzyDX5cWeNnyMk5ASzrsfzN
hYJe3C6mCuqxsctlyDfa6+RqJGUgYXWCKZsXY4YTynaoweIL1acWnaiQQ83S5mjn
m71t95meew8dGYLYY+KGmD4XcGh9N0FLY+9yA2h20M4eqLM7eKeeVfwERTAKDtOg
Cnkd9ZUCEMYlehMfrmkKhMmWXW0ZZHUemVmOV6NJ6UOHoO4i+It0jw==
=xfRd
-----END PGP SIGNATURE-----