Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/pci

> >> Modified Files:
> >>     src/sys/dev/pci: voyagerfb.c
> > 
> >> Log Message:
> >> read 32bits instead of 64bits and truncate the upper 32bits
> > 
> > Please stop making unnecessary changes to drivers you can't test on
> > actual hardware.
> Sorry, should have mentioned this makes the i386 ALL kernel linking.

Adding a bogus fix to make ALL buildable is quite silly.

bus_space_read_8(9) is a documented MI API and
MD implementation should provide bus_space_read_8()
if the machine really needs the driver in its kernel,
or don't enable the device on i386.

Izumi Tsutsui

Home | Main Index | Thread Index | Old Index