Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/i386/stand/lib



On Dec 25, 12:06am, jakllsch%kollasch.net@localhost ("Jonathan A. Kollasch") 
wrote:
-- Subject: Re: CVS commit: src/sys/arch/i386/stand/lib

| On Fri, Dec 24, 2010 at 06:14:13PM -0500, Christos Zoulas wrote:
| > On Dec 24, 11:05pm, jakllsch%kollasch.net@localhost ("Jonathan A. 
Kollasch") wrote:
| > -- Subject: Re: CVS commit: src/sys/arch/i386/stand/lib
| > 
| > | > Are you sure this is right? My guess is that you would need PRId64
| > | > instead of lld.
| > | 
| > | Well, maybe.  But I expect int64_t will always be long long on i386.
| > 
| > Isn't this code shared with amd64? Anyway PRId64 is more correct and
| > works in all cases.
| 
| It is "shared", in the sense that i386 stand code is built as part of
| the amd64 build.  The kernel is responsible for the transition to Long
| Mode.
| 
| Anyway, point taken...

Yes and because all the code is compiled with -m32 %ll will always work
for int64_t because it is going to be long long. Strictly speaking this
is about writing correct code, so always print int64_t with PRId64.

christos


Home | Main Index | Thread Index | Old Index