Re: p9100 bug?

[Michael <macallan%netbsd.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Mar 3, 2010, at 11:18 AM, der Mouse wrote:

> > > sys/dev/sbus/p9100.c (1.34) includes a macro PNOZZ_LATCH [...]
> > > Is this dead code (and thus removal-worthy), or should the
> > > assignment to sc_last_offset in PNOZZ_LATCH be outside the if rather
> > > than inside?
> > No, but the == should be an !=.
>
> !!  Okay, it makes a bit more sense now.  (Doesn't seem to be  
> necessary
> in practice, though, given how basically working the p9100 is.)

Yeah, the SPARCbook docs are often incorrect, it seems to be based on  
docs for older hardware which was updated incompletely. Unfortunately  
we don't know which hardware needs  PNOZZ_LATCH - might be necessary  
for older SPARCbook 3 models or even older revisions of the 3GX.

>  Should I send-pr this or something?

No, I already committed a fix. PNOZZ_LATCH() is optional now, but for  
reasons of paranoia it's enabled in GENERIC and INSTALL. Just get rid  
of the options PNOZZ_USE_LATCH line ( or just don't add it to your  
kernel config )

> I really need to convert that PDF into something usable so I have a
> decent stab at figuring these things out on my own....

Much of it is generic sun4m, only a small subset is SPARCbook  
specific, and what's documented is already implemented. Much of it is  
incorrect, for example half of the chapter about the graphics chip.  
The only piece of hardware in the sparcbook we don't currently support  
is the ISDN interface and that's the same chip used in the SS20 - I  
have the docs if you're interested. Also, we do not currently have  
envsys support for external battery packs, mostly because nobody seems  
to have one.

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBS46698pnzkX8Yg2nAQJCSAf/fZ2btWCYLM0EmWm+K92YGRkGQUYbHVRh
OQKjvGDWw4EMliGEvMpwhyO+PIG62OJAdmtmW/OPNcBgf8+8EE/KiixQW51FRayT
C9EtRI4LDGIwedbXFcumaHD9EwNxUm5T8RIKNiN0hxEyNAyu3MxG8LU2kr1/hr0a
AKfoafdZe5WWHqI9HfJ65vf0Hk9oHU+zJlVu3hPxVzfmVE8WmKVXH95IkH/X/crm
09iNjbe3q2LPHyL4TMhFE36DDuGm/asaCJtQGnpxaO5l+HMbULOZVUtFxQRyBT4J
vsHMk53V4aopfXVyRnvofH40pRs4KRI2Qc/UUQAtIC93Bj6kAVkC0g==
=Bpfm
-----END PGP SIGNATURE-----