Port-sparc archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

p9100 bug?



sys/dev/sbus/p9100.c (1.34) includes a macro PNOZZ_LATCH which is used
in a handful of places.  However, this is dead code; sc->sc_last_offset
is initialized (in various places) to 0xffffffff, and thus will never
match anything &0xffffff80, so PNOZZ_LATCH will never do anything but
make that (failing) comparison.

Is this dead code (and thus removal-worthy), or should the assignment
to sc_last_offset in PNOZZ_LATCH be outside the if rather than inside?

/~\ The ASCII                             Mouse
\ / Ribbon Campaign
 X  Against HTML                mouse%rodents-montreal.org@localhost
/ \ Email!           7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B


Home | Main Index | Thread Index | Old Index