pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Best practices to refresh patches

On 10/5/20 9:52, Jonathan Perkin wrote:
> If updating the line numbers is really important to you and there's a
> case where it would make a difference, then it shouldn't be too
> difficult to add a non-default option to mkpatches for it to update
> them on request.  How's your Perl? ;)

Since I would upgrade mailman package from 2.1.29 to 2.1.33, correcting
line number in the patchfiles would be a drop in the ocean compared with
the churn of the other files.

Too bad I don't know Perl at all.

> As for the contributor guide, I think the main reason that there isn't
> one is because we permit a lot of different ways for people to
> contribute depending on their preferred method.  The important thing
> is that we get a good quality submission - it matters less if it comes
> in via GNATS, mailing list patch, GitHub pull request or issues, patch
> direct to current maintainer, wip commit, etc.

I appreciate flexibility and in fact I would absolutely love to be able
to contribute using my tools of choice like Python and Mercurial.

For me would be trivial to send patches to this mailing list, but it was
suggested yesterday that they would be easily overlooked.

The problem with not documenting anything because there are many
welcomed choices is that a newcomer like me is just unable to decide
what to do and how to proceed.

I just learned that I could submit a mailman upgrade using WIP
repository (I just requested commit access) or just doing a pull request
in github, something I don't entirely understand since the GIT mirror is
documented as a "read only" mirror or the canonical CVS real thing:
<> "Automatic conversion of the NetBSD
pkgsrc CVS module, use with care".

Briefly, newcomers are lost.

> Different developers also have different preferences as to how they
> handle submissions.  For example I utterly detest GNATS and much
> prefer GitHub pull requests, yet other pkgsrc developers have the
> completely opposite opinion.  Thus in my brief guide to fixing
> packages I linked to raising a GitHub issue:

As I understand that, Joyent has a github pkgsrc repository I can do
pull requests to and "magically" somebody else will take care of my PR
and commit it to the master CVS.

Could I use it to push an upgrade to mailman package?

> but this wouldn't be suitable for the primary pkgsrc documentation.

But Joyent repository doesn't handle all cases :).

> We should at least have something though, if someone is able to come
> up with the right wording.

For a newcomer, would be useful to have some guidelines of how to
contribute easily, low friction, tiny learning curve, to whom talk about
this, maybe some mentorship.

So many thing to do, so little time...

If you think this thread is a waste of your time, please let me know.

Jesús Cea Avión                         _/_/      _/_/_/        _/_/_/ -    _/_/    _/_/  _/_/    _/_/  _/_/
Twitter: @jcea                        _/_/    _/_/          _/_/_/_/_/
jabber /  _/_/  _/_/    _/_/          _/_/  _/_/
"Things are not so easy"      _/_/  _/_/    _/_/  _/_/    _/_/  _/_/
"My name is Dump, Core Dump"   _/_/_/        _/_/_/      _/_/  _/_/
"El amor es poner tu felicidad en la felicidad de otro" - Leibniz

Attachment: signature.asc
Description: OpenPGP digital signature

Home | Main Index | Thread Index | Old Index