pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: scmgit-base patch

A few comments:

 Please send the Haiku changes upstream, and add a comment to the patch
 with the link to the upstream bugtracker (I know, that's a mailing list
 archive).  pkgsrc should not be carrying patches long-term that belong

 The autoconf cache line for Haiku does not look wrong, but it is not
 explained.  Please add a comment saying what it's doing, and if this is
 a bug in git or not, and if so file that upstream.

 There's a stray double newline in your patch.

 It's not a big deal, but this is a patch to do two completely unrelated
 things and should be two patches.  Especially for a package of git :-)

Attachment: pgpC50Y5lgGsB.pgp
Description: PGP signature

Home | Main Index | Thread Index | Old Index