wip/eclipse patch for openjdk; can it go to pkgsrc [ Was : devel/eclipse: JRE compatibility question; upgrade needed ]

[Mayuresh <mayuresh%acm.org@localhost>]

On Wed, Nov 14, 2012 at 10:42:26PM +0530, Mayuresh wrote:
> Is the following patc ok? (Just added openjdk and openjdk-bin to
> JVMS_ACCEPTED. Eclipse seemed to launch fine after this though not sure if
> any hidden compatibility issues exist.
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/devel/eclipse/Makefile,v
> retrieving revision 1.30
> diff -u -r1.30 Makefile
> --- Makefile    31 Oct 2012 11:16:54 -0000      1.30
> +++ Makefile    14 Nov 2012 17:06:19 -0000
> @@ -16,7 +16,7 @@
>  DEPENDS+=      apache-ant>=1.4.1:../../devel/apache-ant
>  USE_TOOLS+=    unzip zip
>  
> -PKG_JVMS_ACCEPTED= sun-jdk6 sun-jdk15 sun-jdk14
> +PKG_JVMS_ACCEPTED= sun-jdk6 sun-jdk15 sun-jdk14 openjdk7-bin openjdk7
>  
>  MAKE_ENV+=     JAVA_HOME=${PKG_JAVA_HOME:Q}
>  MAKE_ENV+=     ANT_HOME=${PREFIX:Q}
> 
> 
> Shall try to upgrade eclipse version now.

I realize wip/eclipse already has a later (though not the latest) version.

I have added openjdk to accepted JVM list. If there are no objections,
shall I commit this change?

RCS file: /cvsroot/pkgsrc-wip/wip/eclipse/Makefile,v
retrieving revision 1.3
diff -r1.3 Makefile
15c15
< PKG_JVMS_ACCEPTED= sun-jdk6 sun-jdk15 sun-jdk14
---
> PKG_JVMS_ACCEPTED= sun-jdk6 sun-jdk15 sun-jdk14 openjdk7-bin openjdk7


Is wip/eclipse ripe enough to be imported to devel/eclipse?

Mayuresh.