pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/net/ocamlnet

On 7/17/2012 21:38, Thomas Klausner wrote:
Hi John!

On Tue, Jul 17, 2012 at 05:45:23PM +0000, John Marino wrote:
Module Name:    pkgsrc
Committed By:   marino
Date:           Tue Jul 17 17:45:23 UTC 2012

Modified Files:
        pkgsrc/net/ocamlnet: distinfo
Added Files:
        pkgsrc/net/ocamlnet/patches: patch-src_netsys_netsys__c.c

Log Message:
net/ocamlnet: Fix for systems without AT_SYMLINK_FOLLOW

DragonFly doesn't define AT_SYMLINK_FOLLOW.  The added patch will
appropriately disable linkat support.

No revbump necessary - this patch doesn't change the binary on systems
for which it has already built.

Thanks for the patch. Can you please include these helpful comments in
the patches themselves as well? It helps packagers coming after you to
find out why a patch was added without having to read cvs annotate/cvs
log output; and in general you should assume that there are more
reading patches than writing them.

To make it clearer that comments in patches are a requirement, I've
changed pkglint to make missing patches an error now.

I'd also like to ask you to send the patches upstream. Sending them
upstream is more effort, I know (I've been there, and still am), but
it also builds visibility for DragonFly and helps people after you who
update packages. So I'd appreciate it if you could do that as well. It
will take time away from fixing all packages to build on DragonFly,
but I think the numbers are good enough already that making the rest
build does not have to be the highest priority any longer.

Just to be clear, this mail is not about this packge in particular,
but on patches in pkgsrc in general, and you're not the only
recipient, but you triggered the general reminder.


Okay, submitted here:

I hadn't logged into Sourceforge in like 6 years, and my credentials were disabled due to that security breach they had a few years back. I didn't want to join any more mailing lists, but at least SF let registered members submit patches. The one before it is dated 2002...
Needless to say, this took a lot of time.  :)

So when it's 2019 and time for the next OCAML/Net update, hopefully that's one less patch to worry about.

On a side note:
If pkgsrc was using a different version control than CVS (something like git and the ilk), then reviewing per-patch history on the fly would be a cinch. Rather than use a better VC (and I've heard many of you complain about CVS), we change the process to work around its limitations.

I know its what's being used, but Joerg has Fossil and GIT replicas of Pkgsrc running for many months now. What's stopping the leap?


Home | Main Index | Thread Index | Old Index