Re: panic with NPF tables and debug/lockdebug on amd64

[Geoff Wing <gcw%pobox.com@localhost>]

On Friday 2018-09-28 19:05 +1000, Geoff Wing output:
:Hi,
:I'm seeing a kassert panic with NPF tables and kernel options DEBUG/LOCKDEBUG
:
:config:
:	include "arch/amd64/conf/GENERIC"
:	options		DEBUG
:	options		LOCKDEBUG
:----

Hi,
this is with the nv changes to npf (sources 2018-10-02 06:00 UTC).

(gdb) bt
#0  0xffffffff80222da5 in cpu_reboot (howto=howto@entry=260, bootstr=bootstr@entry=0x0) at /usr/netbsd/src/sys/arch/amd64/amd64/machdep.c:726
#1  0xffffffff809e1949 in vpanic (fmt=fmt@entry=0xffffffff813f4710 "LOCKDEBUG: %s error: %s,%zu: %s", ap=ap@entry=0xffffab8069c78948)
    at /usr/netbsd/src/sys/kern/subr_prf.c:335
#2  0xffffffff809e19e0 in panic (fmt=fmt@entry=0xffffffff813f4710 "LOCKDEBUG: %s error: %s,%zu: %s") at /usr/netbsd/src/sys/kern/subr_prf.c:254
#3  0xffffffff809d82d5 in lockdebug_abort1 (func=0xffffffff81281c20 <__func__.6114> "assert_sleepable", line=70, ld=0xffffab80092246b8, s=6,
    msg=0xffffffff813f4556 "spin lock held", dopanic=<optimized out>) at /usr/netbsd/src/sys/kern/subr_lockdebug.c:807
#4  0xffffffff80993df2 in assert_sleepable () at /usr/netbsd/src/sys/kern/kern_lock.c:70
#5  0xffffffff809df98f in pool_cache_get_paddr (pc=0xffff896889ddb500, flags=flags@entry=1, pap=pap@entry=0x0) at /usr/netbsd/src/sys/kern/subr_pool.c:2283
#6  0xffffffff809d4ff0 in kmem_intr_alloc (requested_size=requested_size@entry=64, kmflags=kmflags@entry=1) at /usr/netbsd/src/sys/kern/subr_kmem.c:268
#7  0xffffffff809d5257 in kmem_intr_zalloc (size=size@entry=64, kmflags=kmflags@entry=1) at /usr/netbsd/src/sys/kern/subr_kmem.c:289
#8  0xffffffff809d55d3 in kmem_zalloc (size=64, kmflags=kmflags@entry=1) at /usr/netbsd/src/sys/kern/subr_kmem.c:375
#9  0xffffffff8076dbd7 in hashmap_rehash (size=<optimized out>, hmap=<optimized out>) at /usr/netbsd/src/sys/net/npf/lpm.c:175
#10 hashmap_insert (len=4, key=0xffffab8069c78b30, hmap=0xffff8968800c91a8) at /usr/netbsd/src/sys/net/npf/lpm.c:204
#11 lpm_insert (lpm=0xffff8968800c9008, addr=addr@entry=0xffff8968828d84d8, len=len@entry=4, preflen=preflen@entry=24, val=val@entry=0xffff8968805daf80)
    at /usr/netbsd/src/sys/net/npf/lpm.c:329
#12 0xffffffff807654e9 in npf_table_insert (t=t@entry=0xffff89687bd74318, alen=<optimized out>, addr=addr@entry=0xffff8968828d84d8, mask=24 '\030')
    at /usr/netbsd/src/sys/net/npf/npf_tableset.c:536
#13 0xffffffff8076085b in npf_mk_table_entries (t=t@entry=0xffff89687bd74318, table=table@entry=0xffff896883a31150, errdict=errdict@entry=0xffff89687bc7b3d0)
    at /usr/netbsd/src/sys/net/npf/npf_ctl.c:130
#14 0xffffffff80760c14 in npf_mk_tables (npf_dict=npf_dict@entry=0xffff896883a31250, errdict=errdict@entry=0xffff89687bc7b3d0,
    tblsetp=tblsetp@entry=0xffffab8069c78cf8, npf=0xffff896851df8f50) at /usr/netbsd/src/sys/net/npf/npf_ctl.c:201
#15 0xffffffff80760fc2 in npfctl_load_nvlist (errdict=0xffff89687bc7b3d0, npf_dict=0xffff896883a31250, npf=0xffff896851df8f50)
    at /usr/netbsd/src/sys/net/npf/npf_ctl.c:535
#16 npfctl_load (npf=0xffff896851df8f50, cmd=<optimized out>, data=0xffffab8069c78ee0) at /usr/netbsd/src/sys/net/npf/npf_ctl.c:599
#17 0xffffffff80a4bf15 in VOP_IOCTL (vp=vp@entry=0xffff896887d43d28, command=command@entry=3222818406, data=data@entry=0xffffab8069c78ee0,
    fflag=<optimized out>, cred=<optimized out>) at /usr/netbsd/src/sys/kern/vnode_if.c:610
#18 0xffffffff80a43144 in vn_ioctl (fp=0xffff8968816d3480, com=3222818406, data=0xffffab8069c78ee0) at /usr/netbsd/src/sys/kern/vfs_vnops.c:769
#19 0xffffffff809ee05b in sys_ioctl (l=<optimized out>, uap=0xffffab8069c79000, retval=<optimized out>) at /usr/netbsd/src/sys/kern/sys_generic.c:671
#20 0xffffffff8024cdd5 in sy_call (rval=0xffffab8069c78fb0, uap=0xffffab8069c79000, l=0xffff896884386980, sy=0xffffffff81653a90 <sysent+1296>)
    at /usr/netbsd/src/sys/sys/syscallvar.h:65
#21 sy_invoke (code=54, rval=0xffffab8069c78fb0, uap=0xffffab8069c79000, l=0xffff896884386980, sy=0xffffffff81653a90 <sysent+1296>)
    at /usr/netbsd/src/sys/sys/syscallvar.h:94
#22 syscall (frame=0xffffab8069c79000) at /usr/netbsd/src/sys/arch/x86/x86/syscall.c:140
#23 0xffffffff802096dd in handle_syscall ()

Regards,
Geoff